Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getContent so body content stream can be accessed on POST method #17425

Closed
wants to merge 5 commits into from

Conversation

xklonx
Copy link
Contributor

@xklonx xklonx commented Oct 6, 2019

I need to get file from body of POST request, but there is no way to get Request->inputStream so i think this fix is correct.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L424 still only mentions put in the exception message

Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
exception message

Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
Signed-off-by: Pavel Krasikov <klonishe@gmail.com>
@xklonx
Copy link
Contributor Author

xklonx commented Nov 1, 2019

Method __get get called before controller execution to get parameters for controller method. Therefore, I think that in switch cases params and parameters, only an parsed array is needed.

@xklonx

This comment has been minimized.

@MorrisJobke

This comment has been minimized.

@skjnldsv skjnldsv requested review from a team, nickvergessen, ArtificialOwl and come-nc and removed request for a team January 17, 2022 08:10
@skjnldsv

This comment has been minimized.

@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Jan 17, 2022
@skjnldsv
Copy link
Member

@xklonx can you rebase and squash all commits into one please?
I don't have that much permissions on your fork :)

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
@come-nc come-nc removed their request for review May 5, 2022 14:45
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz removed this from the Nextcloud 26 milestone Mar 7, 2023
@blizzz
Copy link
Member

blizzz commented Mar 7, 2023

Closing for inactivity. Code needs to be adjusted to current code base, but it should be pretty easy. If someone is interesting in it, open a new PR with the modifications.

@blizzz blizzz closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants