Return the proper jailed path when requesting the root path #16999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/noid/getJailedPath-root
branch
from
eb62bc7
to
64fe9bc
Compare
nickvergessen
approved these changes
Sep 4, 2019
rullzer
approved these changes
Sep 4, 2019
|
/backport to stable16 |
|
/backport to stable15 |
|
backport to stable16 in #17012 |
|
backport to stable15 in #17013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fixes an issue encountered with #16932
To reproduce, try to create a file in the root of a group folder with a rule setup in files_accesscontrol
The issue when creating a directory in the root of a group folder is that the path is not ending with a
/, therefore the check for the matching root path (which is always ending with a/due to the rtrim is failing.So this makes sure the jailed path is returned properly then:
