Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run code coverage CI on merge #16982

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Sep 3, 2019

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer rullzer added the 3. to review Waiting for reviews label Sep 3, 2019
@rullzer rullzer added this to the Nextcloud 17 milestone Sep 3, 2019
Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 👍

@kesselb
Copy link
Contributor

kesselb commented Sep 3, 2019

Make sense!

server/.drone.yml

Lines 21 to 23 in 5462d4b

event:
- pull_request
- push

I think removing pull_request should do the same.

@rullzer
Copy link
Member Author

rullzer commented Sep 3, 2019

Make sense!

server/.drone.yml

Lines 21 to 23 in 5462d4b

event:
- pull_request
- push

I think removing pull_request should do the same.

🤦‍♂️ yes.... of course

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the enh/only_run_codecov_on_merge branch from 608aaf9 to 16477c1 Compare September 3, 2019 16:07
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this works 👍 No codecov jobs here: https://drone.nextcloud.com/nextcloud/server/21354

@kesselb kesselb added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 3, 2019
@rullzer rullzer merged commit de571bd into master Sep 4, 2019
@rullzer rullzer deleted the enh/only_run_codecov_on_merge branch September 4, 2019 06:06
@rullzer rullzer mentioned this pull request Sep 4, 2019
16 tasks
@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2019

/backport to stable16

@kesselb
Copy link
Contributor

kesselb commented Sep 4, 2019

/backport to stable15

@backportbot-nextcloud
Copy link

backport to stable16 in #16995

@backportbot-nextcloud
Copy link

backport to stable15 in #16996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants