Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the save credentials button label #16980

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Change the save credentials button label #16980

merged 1 commit into from
Sep 4, 2019

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Sep 3, 2019

Change the save credentials button label into Save and the email_settings input class
to make sure the word will always fit the button.

ref #16878

@GretaD
Change the save credentials button label and the mail_settings input …
fc83ca7 
…class

Signed-off-by: Greta Doci <gretadoci@gmail.com>
jancborchardt
jancborchardt approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! :)

@GretaD GretaD added 3. to review Waiting for reviews enhancement design Design, UI, UX, etc. labels Sep 3, 2019
@gary-kim gary-kim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2019
@rullzer rullzer merged commit 739e25e into master Sep 4, 2019
@rullzer rullzer deleted the bugfix/16878/change_button_label branch September 4, 2019 06:54
@rullzer rullzer mentioned this pull request Sep 4, 2019
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@gary-kim gary-kim gary-kim approved these changes

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GretaD @jancborchardt @gary-kim @rullzer