Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define a guest type so Talk can use it in it's notifications #16968

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Define a guest type so Talk can use it in it's notifications #16968

merged 1 commit into from
Sep 2, 2019

Conversation

nickvergessen
Copy link
Member

  • Talk has guest mentions since 17
  • If you mention a guest and a normal user the notification is created correctly for the normal user
  • But it can not be rendered because guest is not a valid parameter type so far.

@nickvergessen
Define a guest type so Talk can use it in it's notifications
60fe0d7 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 17 milestone Sep 2, 2019
This was referenced Sep 2, 2019
Closed
Merged
@rullzer rullzer merged commit 80d272c into master Sep 2, 2019
@rullzer rullzer deleted the feature/noid/guest-mention-notifications-for-talk branch September 2, 2019 18:14
danxuliu
danxuliu reviewed Sep 2, 2019
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am late to the party, but... tested and works 👍 :-P

@rullzer rullzer mentioned this pull request Sep 4, 2019
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu left review comments

@rullzer rullzer rullzer approved these changes

@Ivansss Ivansss Ivansss approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: activity and notification high regression
Projects
None yet
Milestone
Nextcloud 17
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @rullzer @Ivansss @danxuliu