Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references #162

Merged
merged 10 commits into from
Jun 20, 2016
Merged

Fix references #162

merged 10 commits into from
Jun 20, 2016

Conversation

MorrisJobke
Copy link
Member

No description provided.

@MorrisJobke MorrisJobke added this to the Nextcloud 10 milestone Jun 20, 2016
@MorrisJobke MorrisJobke changed the title [WIP] Fix reference to ownCloud [WIP] Fix references Jun 20, 2016
@MorrisJobke MorrisJobke changed the title [WIP] Fix references Fix references Jun 20, 2016
@MorrisJobke MorrisJobke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 20, 2016
@schiessle
Copy link
Member

schiessle commented Jun 20, 2016

👍

@LukasReschke
Copy link
Member

LukasReschke commented Jun 20, 2016

LGTM

@MorrisJobke MorrisJobke merged commit 22fd331 into master Jun 20, 2016
@MorrisJobke MorrisJobke deleted the fix-owncloud-reference branch June 20, 2016 12:19
@@ -44,7 +44,7 @@
"New recovery key password" : "Fjalëkalimi i ri kyçi rimarrjesh",
"Repeat new recovery key password" : "Rijepni fjalëkalimin e ri kyçi rimarrjesh",
"Change Password" : "Ndryshoni Fjalëkalimin",
"ownCloud basic encryption module" : "modul i thjeshtë ownCloud fshehtëzimesh",
"basic encryption module" : "modul i thjeshtëfshehtëzimesh",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MorrisJobke don't think this is supposed to be written together

@@ -44,7 +44,7 @@ OC.L10N.register(
"New recovery key password" : "Novi ključ za obnovitev gesla",
"Repeat new recovery key password" : "Ponovi novi ključ za obnovitev gesla",
"Change Password" : "Spremeni geslo",
"ownCloud basic encryption module" : "Osnovno šifriranje z ownCloud",
"basic encryption module" : "Osnovno šifriranje z",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MorrisJobke remove "z"

@vincchan
Copy link
Member

vincchan commented Jun 20, 2016

@MorrisJobke whoops!! I was just reviewing the files when you merged the PR :/

@MorrisJobke
Copy link
Member Author

@vincchan I know that there are issues in some languages. Those then needs to be fixed in the transifex setup.

@MorrisJobke
Copy link
Member Author

I just talked with @schiessle and it's maybe better to do on stable9 a s/ownCloud/Nextcloud/ and on master a proper fixing of the strings. That then keeps the translations for the next releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants