Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sharing in menu in grid view #14695

Merged
merged 3 commits into from
Mar 21, 2019
Merged

Show sharing in menu in grid view #14695

merged 3 commits into from
Mar 21, 2019

Conversation

skjnldsv
Copy link
Member

Capture d’écran_2019-03-14_17-57-11
Capture d’écran_2019-03-14_17-57-20
Capture d’écran_2019-03-14_17-57-32

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv skjnldsv added this to the Nextcloud 16 milestone Mar 14, 2019
@skjnldsv skjnldsv self-assigned this Mar 14, 2019
@skjnldsv skjnldsv force-pushed the enhancement/grid/sharing-in-menu branch from 20018ab to 615c069 Compare March 14, 2019 17:59
@jancborchardt
Copy link
Member

Was just comparing with the right-click menu and also with our logical sorting – and I have to correct myself: Let’s put the "Share" action first in the list, above "Favorites" rather than below. Since elsewhere it’s always the first action, even being outside of the menu. :)

Otherwise awesome! 🎉

jancborchardt
jancborchardt requested changes Mar 15, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said let’s put Share as first entry in the menu (sorry for the confusion) then it’s 👍 :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 15, 2019 •
edited
Loading

As said let’s put Share as first entry in the menu (sorry for the confusion) then it’s :)

Above favorite? just read the message above! :)
👌

@skjnldsv
Copy link
Member Author

@jancborchardt done! 😉

@MorrisJobke
Copy link
Member

It now only shows "Shared" for me with the normal share icon instead of the little chain for public links or the avatar for user/group shares. 😢

@skjnldsv
Copy link
Member Author

It now only shows "Shared" for me with the normal share icon instead of the little chain for public links

I guess I missed some check :)

or the avatar for user/group shares.

But this is only on incoming shares, right?

@MorrisJobke
Copy link
Member

But this is only on incoming shares, right?

Ah - right.

jancborchardt
jancborchardt approved these changes Mar 15, 2019
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@skjnldsv skjnldsv mentioned this pull request Mar 16, 2019
Merged
@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 19, 2019
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
@MorrisJobke
Copy link
Member

@skjnldsv Mind to fix the unit tests and conflicts?

@skjnldsv
Copy link
Member Author

@skjnldsv in my todo for today :)

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 21, 2019
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 21, 2019 •
edited
Loading

Fixed, rebased and ready to go 🚀

skjnldsv added 3 commits March 21, 2019 08:14
@skjnldsv
Show sharing in menu in grid view
4ad922d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Put sharing entry all above
4c884f1 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
Add link icon for public link too
ff164db 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the enhancement/grid/sharing-in-menu branch from 17ec4c1 to ff164db Compare March 21, 2019 07:16
MorrisJobke
MorrisJobke approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 21, 2019
@faily-bot
Copy link

faily-bot bot commented Mar 21, 2019

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 17201: failure

TESTS=ui-regression

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

@MorrisJobke MorrisJobke merged commit 2389b61 into master Mar 21, 2019
@MorrisJobke MorrisJobke deleted the enhancement/grid/sharing-in-menu branch March 21, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: files feature: sharing
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @jancborchardt @MorrisJobke @juliusknorr