Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow renaming the root of a movable mount even if the parent folder … #14689

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

icewind1991
Copy link
Member

…is readonly

Signed-off-by: Robin Appelman robin@icewind.nl

…is readonly

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Mar 14, 2019
@icewind1991 icewind1991 added this to the Nextcloud 16 milestone Mar 14, 2019
@MorrisJobke
Copy link
Member

Related to #14691

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane.

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 14, 2019
@rullzer rullzer merged commit 6f88f28 into master Mar 15, 2019
@rullzer rullzer deleted the rename-moveable-mount-readonly-parent branch March 15, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants