Allow bracket IPv6 address format inside IPAdress Normalizer #13327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When run with php's build-in server (for instance on localhost:8080), IP provided through $this->server['REMOTE_ADDR'] is [::1], which is not an acceptable format for \inet_pton. This removes the brackets if there's any. Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
added
3. to review
kesselb
reviewed
Feb 19, 2019
| @@ -68,6 +68,9 @@ private function getIPv4Subnet(string $ip, int $maskBits = 32): string { | |||
| * @return string | |||
| */ | |||
| private function getIPv6Subnet(string $ip, int $maskBits = 48): string { | |||
| if ($ip[0] === '[' && $ip[-1] === ']') { // If IP is with brackets, for example [::1] | |||
There was a problem hiding this comment.
trim($ip, '[]')) would also work.
|
@ChristophWurst Mind to review this one? |
ChristophWurst
approved these changes
Mar 6, 2019
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #13943
When run with php's build-in server (for instance on
localhost:8080), IP provided through$this->server['REMOTE_ADDR']is[::1], which is not an acceptable format for \inet_pton.I didn't dig why I've got an IPv6 localhost or anything, but I guess it's still valid.
This removes the brackets if there's any.