Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Added cache override to ensure an always up-to-date accessibility css #12432

Merged
merged 1 commit into from
Nov 14, 2018
Merged

[stable14] Added cache override to ensure an always up-to-date accessibility css #12432

merged 1 commit into from
Nov 14, 2018

Conversation

skjnldsv
Copy link
Member

Backport of #11533

@skjnldsv
Added cache override to ensure an always up-to-date accessibility css
1aac8d8 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Nov 13, 2018
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: caching Related to our caching system: scssCacher, jsCombiner... labels Nov 13, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14.0.4 milestone Nov 13, 2018
@skjnldsv skjnldsv mentioned this pull request Nov 13, 2018
Merged
@MorrisJobke MorrisJobke mentioned this pull request Nov 13, 2018
Merged
@ChristophWurst ChristophWurst changed the title Added cache override to ensure an always up-to-date accessibility css [stable14] Added cache override to ensure an always up-to-date accessibility css Nov 13, 2018
MorrisJobke
MorrisJobke approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

JanDragon
JanDragon approved these changes Nov 13, 2018
View reviewed changes
Copy link

@JanDragon JanDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its Work

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 14, 2018
@MorrisJobke MorrisJobke merged commit fc516b5 into stable14 Nov 14, 2018
@MorrisJobke MorrisJobke deleted the stb14-accessibility-cache-fixes branch November 14, 2018 15:54
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@JanDragon JanDragon JanDragon approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@rullzer rullzer Awaiting requested review from rullzer

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caching Related to our caching system: scssCacher, jsCombiner...
Projects
None yet
Milestone
Nextcloud 14.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @MorrisJobke @JanDragon @ChristophWurst