Remove cookies from Clear-Site-Data Header

[iPaat]

In 2f87fb6 this header was introduced. The referenced documentation says:

When delivered with a response from https://example.com/clear, the following header will cause cookies associated with the origin https://example.com to be cleared, as well as cookies on any origin in the same registered domain (e.g. https://www.example.com/ and https://more.subdomains.example.com/).

This also applies if https://nextcloud.example.com/ sends the Clear-Site-Data: "cookies" header.
This is not the behavior we want at this point!

So I removed the deletion of cookies from the header. This has no effect on the logout process as this header is supported only recently and the logout works in old browsers as well.

---

Fix #9010

[iPaat]

Hi,

is there a reason why a test that has nothing to do with my changes fails?
https://drone.nextcloud.com/nextcloud/server/11516/267 - Line: 233 Scenario: create tags using the Administration settings

Best,
Patrick

[DominikWA]

This fix is really good. The problem described has a big impact of users. I administer multiple Nextcloud instances, when users log out from the Nextcloud web interface they are log out from every other service which shares the same domain name. That affects email (webclient) and other webapps, the users needs to re-login in every service, which is time consuming. In my opinion Nextcloud should not affect other tabs or services.

[MorrisJobke]

Tested and works 👍

[MorrisJobke]

CI failure unrelated

[MorrisJobke]

@iPaat Could I ask you to open a backport pull request? Basically check out stable14, create a branch, cherry-pick the commit in here and open a PR with stable14 as base branch. The same for stable13 would also make sense.

[MorrisJobke]

Thanks a lot for your contribution. And maybe have a look at the "good first issue" labeled issues ;) https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22