-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose password confirmation capabilities in the user backend #11786
Conversation
lib/public/IUser.php
Outdated
@@ -108,6 +108,13 @@ public function getHome(); | |||
*/ | |||
public function getBackendClassName(); | |||
|
|||
/** | |||
* Get the backend for the ccurrent user object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
9f6327b
to
d8fb024
Compare
All done. |
On some backends (saml for example) users can't revalidate their passwords as Nextcloud has no way to do verify it. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
If the userbackend doesn't allow validating the password for a given uid then there is no need to perform this check. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
d8fb024
to
90c4b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code makes sense 👍 Tested and works 🎉
This will allow user backends to expose if a users password can be validated. This can be useful in several places and allows us to proper do instanceof checks instead of magic string comparisons.
@blizzz as discussed.