Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Ignore "session_lifetime" if it can not be converted to a number #11761

Merged
merged 1 commit into from
Oct 11, 2018
Merged

[stable14] Ignore "session_lifetime" if it can not be converted to a number #11761

merged 1 commit into from
Oct 11, 2018

Conversation

danxuliu
Copy link
Member

Backport of #11756

@danxuliu
Ignore "session_lifetime" if it can not be converted to a number
a246cc1 
When "session_lifetime" can not be converted to a number the interval
becomes a NaN due to dividing it by 2. This NaN was "dragged" over all
the other mathematical operations and caused the csrftoken to be got
again and again due to an infinite loop with no pauses in "setInterval".
Now, the interval is set to the default value instead if the
"session_lifetime" can not be converted to a number.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added bug 3. to review Waiting for reviews labels Oct 11, 2018
@danxuliu danxuliu added this to the Nextcloud 14.0.3 milestone Oct 11, 2018
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 11, 2018
@MorrisJobke
Copy link
Member

CI just ran into timeouts due to load.

@MorrisJobke MorrisJobke merged commit feb8a79 into stable14 Oct 11, 2018
@MorrisJobke MorrisJobke deleted the stable14-11756-ignore-session-lifetime-if-it-can-not-be-converted-to-a-number branch October 11, 2018 11:25
@rullzer rullzer mentioned this pull request Oct 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 14.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@danxuliu @MorrisJobke @nickvergessen @rullzer