Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix call to logger #11603

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Fix call to logger #11603

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1986c1f
Fix call to logger
kesselb Oct 3, 2018
1243cae
Append error from exception for message
kesselb Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/theming/lib/ImageManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public function getImage(string $key, bool $useSvg = true): ISimpleFile {
$pngFile = $folder->newFile($key . '.png');
$pngFile->putContent($finalIconFile->getImageBlob());
} catch (\ImagickException $e) {
$this->logger->info('The image was requested to be no SVG file, but converting it to PNG failed.', $e->getMessage());
$this->logger->info('The image was requested to be no SVG file, but converting it to PNG failed.', [$e->getMessage()]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should add it to the message otherwise it's just lost. Could you add it to the message itself by string concatenation?

$pngFile = null;
}
} else {
Expand Down