Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix sticky header on users list #11582

Merged
merged 1 commit into from
Oct 3, 2018
Merged

[stable14] Fix sticky header on users list #11582

merged 1 commit into from
Oct 3, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 3, 2018

Backport Fix sticky header on users list #11581

@skjnldsv
Fix sticky header on users list
b9d273b 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. feature: users and groups labels Oct 3, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14.0.2 milestone Oct 3, 2018
@skjnldsv skjnldsv self-assigned this Oct 3, 2018
@skjnldsv skjnldsv changed the title Fix sticky header on users list [stable14] Fix sticky header on users list Oct 3, 2018
ChristophWurst
ChristophWurst approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and I think @MorrisJobke tested it 👍 🙈

MorrisJobke
MorrisJobke approved these changes Oct 3, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍 (same as with the master PR: border at bottom would be nice, but I'm fine with a followup PR)

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
@MorrisJobke MorrisJobke merged commit 5b33cbd into stable14 Oct 3, 2018
@MorrisJobke MorrisJobke deleted the stb14-users-table-header-fix branch October 3, 2018 12:54
@MorrisJobke MorrisJobke restored the stb14-users-table-header-fix branch October 3, 2018 12:54
@ChristophWurst ChristophWurst deleted the stb14-users-table-header-fix branch October 3, 2018 12:55
@MorrisJobke MorrisJobke mentioned this pull request Oct 3, 2018
Merged
@skjnldsv skjnldsv mentioned this pull request Oct 4, 2018
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 4, 2018

@MorrisJobke follow-up: #11608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@weeman1337 weeman1337 Awaiting requested review from weeman1337

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: users and groups papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 14.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @ChristophWurst