Just update password hash without validating #11568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/private/User/Database.php
Outdated
| @@ -314,7 +314,11 @@ public function checkPassword(string $uid, string $password) { | |||
| $newHash = ''; | |||
| if (\OC::$server->getHasher()->verify($password, $storedHash, $newHash)) { | |||
| if (!empty($newHash)) { | |||
| $this->setPassword($uid, $password); | |||
| $qb = $this->dbConn->getQueryBuilder() | |||
There was a problem hiding this comment.
Could we add a bool $silent param instead? I'm not a big fan of this duplication.
There was a problem hiding this comment.
fair enough. Extracted the logic to a function
Fixes #11097 If your password hash changed (becuse your are on 7.2 and we moved to ARGON2). Then we shold not 'set a new password' but just update the hash. As else we invoke the password policy again which might lock out users. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
fix/11097/just_update_password_hash
branch
from
e107585
to
0c9a3de
Compare
MorrisJobke
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11097
If your password hash changed (becuse your are on 7.2 and we moved to
ARGON2). Then we shold not 'set a new password' but just update the
hash. As else we invoke the password policy again which might lock out
users.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl