Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Get permission of storage for shares #11287

Merged
merged 4 commits into from
Sep 20, 2018
Merged

[stable14] Get permission of storage for shares #11287

merged 4 commits into from
Sep 20, 2018

Commits on Sep 19, 2018

  1. Check the permission of the underlying storage 

    Else shares might expose more permissions than the storage actually
providers.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
    @rullzer @nickvergessen
    rullzer authored and nickvergessen committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    4cc8cdc View commit details
    Browse the repository at this point in the history

  2. Fix shared cache 

    Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
    @rullzer @nickvergessen
    rullzer authored and nickvergessen committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    43f73ad View commit details
    Browse the repository at this point in the history

  3. Properly check share permissions 

    isCreatable only works on folders
isUpdatable if the file is not there but it is a part file also has to
be checked on the folder

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
    @rullzer @nickvergessen
    rullzer authored and nickvergessen committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    b66b2de View commit details
    Browse the repository at this point in the history

  4. Update test now that we check permissions properly 

    Now that we actually check thepermissions properly we have to update the
tests.

* We checked an invalid path
* We checked from wrong permissions (files never have CREATE permissions
for example)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
    @rullzer @nickvergessen
    rullzer authored and nickvergessen committed Sep 19, 2018
    Configuration menu
    Copy the full SHA
    5e13368 View commit details
    Browse the repository at this point in the history