fix check for more users in sharing dialogue #11036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
commented
Sep 3, 2018
| @@ -557,7 +570,7 @@ | |||
| $shareWithField.focus(); | |||
| }; | |||
|
|
|||
| var perPage = 200; | |||
| var perPage = parseInt(oc_config['sharing.maxAutocompleteResults'], 10) || 200; | |||
There was a problem hiding this comment.
this, we actually could hardcode to 2, as it just checks for success as far as i see.
after a refactor users et al were undefined. The check condition was moved. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/10903/users-undefined-maxautocompleteresults
branch
from
cc326df
to
118f2fc
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/10903/users-undefined-maxautocompleteresults
branch
from
118f2fc
to
b628ec4
Compare
|
reviews, pozhaluysta? 😸 |
nickvergessen
approved these changes
Sep 13, 2018
skjnldsv
approved these changes
Sep 13, 2018
nickvergessen
deleted the
fix/10903/users-undefined-maxautocompleteresults
branch
blizzz
added a commit
that referenced
this pull request
Sep 13, 2018
fix check for more users after a refactor users et al were undefined. The check condition was moved. Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> don't user a higher paging size than max autocomplete entries are set Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> adjust and extend js unit tests Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #10903 (see this also for reproduction steps)