Bug/noid/fix missing quickaccess favorite folder on add

[newhinton]

When you mark a folder as favorite, it should be added to the quickaccessbar. This is not the case, because the route for checking if the newly marked element is a folder or a directory is missing. This PR readds the missing route.

[ChristophWurst]

Hey, @newhinton,

thanks a lot for this fix. Could you please provide some reproduction steps for this? I don't fully understand your description, so I couldn't reproduce the problem.

Why do you mean by 'quickaccessbar'? The left sidebar in the files app?

[ChristophWurst]

Oh, and commit 8d38f80 seems to be unrelated to this fix, correct?

[newhinton]

yeah, 8d38f80 belongs to #10887 (actually, it IS #10887)
it must have sneeked in here

The quickaccessbar is the dropdown which gets added to the favorites-navigation-element in the filesapp navigation bar.

There are currently two ways do add an item to the bar:
Mark a folder as favorite with a right-klick;
Open details of said folder and klick the star in the details-bar;

Both should immediately add the folder to the quickaccess, which does not happen, because there is a route missing.

To make them show up, you need to reload the page

[skjnldsv]

Rebased

[MorrisJobke]

@skjnldsv Conflicting

[juliushaertl]

@newhinton Can you rebase the changes and remove the unrelated 5d2ca94 commit? Otherwise it looks good from my side.

[newhinton]

@juliushaertl should be fine now :)

[rullzer]

mmm are we missing commits here?

[newhinton]

@rullzer What do you mean? Is this fix not working?

[juliushaertl]

@rullzer Doesn't seem so 😉

Tested and works as expected 👍

CI failure seems unrelated:

  Scenario: change email                                               # /drone/src/github.com/nextcloud/server/tests/acceptance/features/users.feature:136
    Given I act as Jane                                                # ActorContext::iActAs()
    And I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                       # SettingsMenuContext::iOpenTheUserSettings()
    And I see that the list of users contains the user user0           # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I see that the mailAddress of user0 is ""                      # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
    When I set the mailAddress for user0 to "test@nextcloud.com"       # UsersSettingsContext::iSetTheFieldForUserTo()
    And I see that the mailAddress cell for user user0 is done loading # UsersSettingsContext::iSeeThatTheCellForUserIsDoneLoading()
    Then I see that the mailAddress of user0 is "test@nextcloud.com"   # UsersSettingsContext::iSeeThatTheFieldOfUserIs()
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -''
      +'test@nextcloud.com'

[MorrisJobke]

@newhinton Mind to backport this to stable14?

[newhinton]

@MorrisJobke I will try to do it on the weekend, i just create a pr with the fixes to stable14 right?

[juliushaertl]

@newhinton Yes, we do backports by cherry picking the changes. The following git commands should do the job for this PR:

# checkout stable14 branch
git checkout stable14
# update branch to latest state
git pull
# create a new branch for the backport
git checkout stable14-10888
# cherry pick the commit from this pr into the backport branch
git cherry-pick 8dc449990dcd5a62e4280c1af9769582cf0a719a
# push your branch
git push

[MorrisJobke]

@newhinton Do you need any further help for the backport? I plan to do the RC for the maintenance releases on Thursday so it should be back ported by then.

[newhinton]

@MorrisJobke No, i just didn't found the time, but i will do it today, so there should be a PR ready tomorrow morning

[MorrisJobke]

@MorrisJobke No, i just didn't found the time, but i will do it today, so there should be a PR ready tomorrow morning

Perfect. If you need help then we are here to do so :)

[newhinton]

@MorrisJobke Done! :D

[MorrisJobke]

@MorrisJobke Done! :D

Thanks 👍