Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check before running "upgrade" if cronjob is still running and wait for it to finish #9562

Closed
MorrisJobke opened this issue May 23, 2018 · 2 comments · Fixed by #9900
Closed

Check before running "upgrade" if cronjob is still running and wait for it to finish #9562

MorrisJobke opened this issue May 23, 2018 · 2 comments · Fixed by #9900
Labels
enhancement feature: install and update
Milestone
Nextcloud 14

Comments

@MorrisJobke
Copy link
Member

Basically #5172 doesn't work because it does not reload the content of the config.php. So it's maybe better to check if the cronjob currently runs and wait for it to finish. It should be possible to cancel this waiting and it also should not have any impact at all.

As discussed with @rullzer

cc @ChristophWurst @skjnldsv @nickvergessen
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone May 23, 2018
This was referenced May 23, 2018
Closed
Closed
MorrisJobke added a commit that referenced this issue Jun 18, 2018
@MorrisJobke
Wait for cron to finish before running upgrade command
b0c929d 
* fixes #9562

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke mentioned this issue Jun 18, 2018
Merged
@MorrisJobke
Copy link
Member Author

Fix is in #9900

MorrisJobke added a commit that referenced this issue Jun 19, 2018
@MorrisJobke
Wait for cron to finish before running upgrade command
18e9631 
* fixes #9562

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@nextcloud-bot nextcloud-bot mentioned this issue Aug 31, 2018
Closed
@MorrisJobke
Copy link
Member Author

Reverted in #12188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature: install and update
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging a pull request may close this issue.

Wait for cron to finish before running upgrade command nextcloud/server
1 participant
@MorrisJobke