Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon color is a bit off? #5193

Closed
nickvergessen opened this issue May 31, 2017 · 3 comments · Fixed by #6460
Closed

Favicon color is a bit off? #5193

nickvergessen opened this issue May 31, 2017 · 3 comments · Fixed by #6460
Labels
3. to review Waiting for reviews bug feature: theming
Milestone
Nextcloud 13

Comments

@nickvergessen
Copy link
Member

I noticed it on my bookmarks, since 12 the app icon is used, but the blue tone is wrong. It is #5980C2 while the theme is #0182C9

bildschirmfoto vom 2017-05-31 12-44-17

@juliushaertl
@nickvergessen nickvergessen added this to the Nextcloud 13 milestone May 31, 2017
@juliushaertl
Copy link
Member

Can you check what color the icon has if you download it manually from index.php/apps/theming/icon

Looks more like a browser caching issue to me.

@juliushaertl
Copy link
Member

I did some testing and it seems that this is caused by the browser resizing the icon to 16x16px. The theming app should create a favicon file in ico format that contains various sizes. I'll look into that.

@juliushaertl juliushaertl self-assigned this Jun 6, 2017
@jancborchardt
Copy link
Member

For the record, the correct Nextcloud color is #0082c9 :) (not 01…)

juliushaertl added a commit that referenced this issue Sep 12, 2017
@juliushaertl
Theming: Generate favicon sizes to avoid resizing issues done by the …
2fa2785 
…browser

fixes #5193

Signed-off-by: Julius Haertl <jus@bitgrid.net>
@juliushaertl juliushaertl mentioned this issue Sep 12, 2017
Merged
@juliushaertl juliushaertl removed their assignment Sep 12, 2017
@juliushaertl juliushaertl added the 3. to review Waiting for reviews label Sep 12, 2017
juliushaertl added a commit that referenced this issue Sep 17, 2017
@juliushaertl
Theming: Generate favicon sizes to avoid resizing issues done by the …
90c0f8f 
…browser

fixes #5193

Signed-off-by: Julius Haertl <jus@bitgrid.net>
juliushaertl added a commit that referenced this issue Sep 17, 2017
@juliushaertl
Theming: Generate favicon sizes to avoid resizing issues done by the …
3fc0e36 
…browser

fixes #5193

Signed-off-by: Julius Haertl <jus@bitgrid.net>
juliushaertl added a commit that referenced this issue Sep 23, 2017
@juliushaertl
Theming: Generate favicon sizes to avoid resizing issues done by the …
4fa99a7 
…browser

fixes #5193

Signed-off-by: Julius Haertl <jus@bitgrid.net>
juliushaertl added a commit that referenced this issue Nov 13, 2017
@juliushaertl
Theming: Generate favicon sizes to avoid resizing issues done by the …
31b9fc9 
…browser

fixes #5193

Signed-off-by: Julius Haertl <jus@bitgrid.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: theming
Projects
None yet
Milestone
Nextcloud 13
Development

Successfully merging a pull request may close this issue.

Theming: Generate different favicon sizes nextcloud/server
3 participants
@nickvergessen @jancborchardt @juliushaertl