fix(caldav): allow VJOURNAL if no supported component set is specified

[st3iny]

• Resolves: [Bug]: MKCALENDAR without supported-calendar-component-set doesn't support journals by default #45709

Summary

The CalDAV RFC says:

In the absence of this property [supported-calendar-component-set], the server MUST accept all component types, and the client can assume that all component types are accepted.

So collections that are created without supported-calendar-component-set should also support journals.

TODO

• Probably tests

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[miaulalala]

Have you tested it with our frontend? Will it display? Because \OCA\DAV\CalDAV\CalDavBackend::getCalendarsForUser will give you all supported component sets

[st3iny]

Our own client, the Calendar app, should be fine. It ignores everthing other than VEVENT and VTODO. However, I'm still searching for an application that support VJOURNALS to actually test it.

Unfortunately, jtxboard on Android can't sync with CalDAV anymore on the free version 😕

[lmouelle]

Our own client, the Calendar app, should be fine. It ignores everthing other than VEVENT and VTODO. However, I'm still searching for an application that support VJOURNALS to actually test it.

Unfortunately, jtxboard on Android can't sync with CalDAV anymore on the free version 😕

Jumping into this issue from a davx5 discussion I opened here, the free version of jtx board in f-droid can do CalDAV sync, that's what I've been using.

Evolution/GNOME email client also can do CalDAV sync, VJOURNAL shows in the "memos" section of the desktop app

[st3iny]

Thanks for the tip! I was finally able to do some testing with GNOME Evolution and it works fine.

The backend handles VJOURNALs out of the box and the Calendar app simply ignores them.