Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: When drag and drop multiple files, only one is loaded [blink engine] #43074

Closed
4 of 8 tasks
Tracked by #3888
SHellSys opened this issue Jan 24, 2024 · 34 comments · Fixed by #44254
Closed
4 of 8 tasks
Tracked by #3888

[Bug]: When drag and drop multiple files, only one is loaded [blink engine] #43074

SHellSys opened this issue Jan 24, 2024 · 34 comments · Fixed by #44254

Comments

@SHellSys
Copy link

SHellSys commented Jan 24, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

After Upgrade to 28.0.2 RC1: When dragging multiple files into Nextcloud for upload only one file will be uploaded if I use Edge. On Firefox, all files will be uploaded.

This only happens with the Blink engine (Chromium, Edge, Opera), Firefox is not affected

Steps to reproduce

  1. Open target folder in Nextcloud in Edge
  2. Drag multiple files for upload onto the upload area
  3. Check which files have been uploaded

Expected behavior

All files should be uploaded.

Installation method

None

Nextcloud Server version

28

Operating system

Debian/Ubuntu

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "28.0.2.0",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "skeletondirectory": "\/var\/www\/html\/nextcloud\/core\/comp",
        "memcache.local": "\\OC\\Memcache\\APCu",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "remember_login_cookie_lifetime": 1296000,
        "session_lifetime": 172800,
        "session_keepalive": true,
        "token_auth_enforced": false,
        "filelocking.enabled": "true",
        "trashbin_retention_obligation": "auto,1",
        "versions_retention_obligation": "disabled",
        "maintenance_window_start": 1,
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0,
            "timeout": 0
        },
        "ldapIgnoreNamingRules": false,
        "ldapProviderFactory": "\\OCA\\User_LDAP\\LDAPProviderFactory",
        "updater.release.channel": "stable",
        "maintenance": false,
        "defaultapp": "files",
        "theme": "",
        "loglevel": 0,
        "mail_smtpmode": "smtp",
        "mail_smtpauthtype": "PLAIN",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "default_phone_region": "DE"
    }
}

List of activated Apps

Enabled:
  - activity: 2.20.0
  - circles: 28.0.0-dev
  - cloud_federation_api: 1.11.0
  - contactsinteraction: 1.9.0
  - dav: 1.29.1
  - federatedfilesharing: 1.18.0
  - files: 2.0.0
  - files_external: 1.20.0
  - files_reminders: 1.1.0
  - files_sharing: 1.20.0
  - files_trashbin: 1.18.0
  - files_versions: 1.21.0
  - firstrunwizard: 2.17.0
  - logreader: 2.13.0
  - lookup_server_connector: 1.16.0
  - notifications: 2.16.0
  - oauth2: 1.16.3
  - password_policy: 1.18.0
  - photos: 2.4.0
  - privacy: 1.12.0
  - provisioning_api: 1.18.0
  - recommendations: 2.0.0
  - related_resources: 1.3.0
  - serverinfo: 1.18.0
  - settings: 1.10.1
  - sharebymail: 1.18.0
  - text: 3.9.1
  - theming: 2.3.0
  - twofactor_backupcodes: 1.17.0
  - updatenotification: 1.18.0
  - user_ldap: 1.19.0
  - user_status: 1.8.1
  - viewer: 2.2.0
  - workflowengine: 2.10.0
Disabled:
  - admin_audit: 1.18.0
  - bruteforcesettings: 2.8.0
  - comments: 1.18.0 (installed 1.2.0)
  - dashboard: 7.8.0 (installed 7.5.0)
  - encryption: 2.16.0
  - federation: 1.18.0 (installed 1.2.0)
  - files_automatedtagging: 1.18.0 (installed 1.18.0)
  - files_pdfviewer: 2.9.0 (installed 1.2.1)
  - files_retention: 1.17.0 (installed 1.17.0)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - nextcloud_announcements: 1.17.0 (installed 1.1)
  - polls: 6.0.1 (installed 6.0.1)
  - support: 1.11.0 (installed 1.8.0)
  - survey_client: 1.16.0 (installed 1.0.0)
  - suspicious_login: 6.0.0
  - systemtags: 1.18.0 (installed 1.2.0)
  - twofactor_totp: 10.0.0-beta.2
  - weather_status: 1.8.0 (installed 1.5.0)

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@SHellSys SHellSys added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jan 24, 2024
@skjnldsv
Copy link
Member

Hey, thanks fr the reprt :)
When you say on Edge, have you tried other browsers and they're working? Or you only tried it on Edge

@SHellSys
Copy link
Author

Hey, thanks fr the reprt :) When you say on Edge, have you tried other browsers and they're working? Or you only tried it on Edge

The error occured on Microsoft Edge 120.0.2210.91
Firefox 121.0.1 works fine

@bravedave
Copy link

I've just upgrade to 28.02 and am seeing a similar issue

If I upload using the New > Upload files method - no issue
If I upload via Drag & Drop, only the first file is uploaded

I'm using Brave, and have checked in Chrome - same result

Brave is Version 1.62.156 (latest) on Win 11

@skjnldsv skjnldsv changed the title [Bug]: Upload of multiple files in Edge not possible [Bug]: When drag and drop multiple files, only one is loaded Feb 2, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Feb 2, 2024

I can reproduce the issue
Let's wait for #43267 and move on from here! 🚀

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of medium and removed needs info 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Feb 2, 2024
@stijink

This comment was marked as spam.

@nickian

This comment has been minimized.

@bravedave

This comment was marked as off-topic.

@arnowelzel
Copy link
Contributor

I agree that the current solution using a "drag & drop" area is a worse experience compared to how it was before.

Having a visual indicator as feedback that the Nextcloud file manager will accept the dropped files as upload is OK, but only accepting them in a limited "drag here" area is the complete opposite to how desktop file managers work. Older version of Nextcloud accepted files anway in the viewport and not just in certain spots.

@skjnldsv

This comment was marked as resolved.

@szaimen

This comment was marked as spam.

@krzys-h

This comment was marked as duplicate.

@AInteriorB

This comment has been minimized.

@LM-vb

This comment was marked as spam.

@susnux
Copy link
Contributor

susnux commented Mar 1, 2024

This bug is still present in 28.0.3 (Edge + Chrome, Win 10).

Yes as you can see the bug is still open (!) meaning it is not resolved. This is a blink engine issue and we need to find a workaround for broken blink browsers like Chrome, Chromium, Edge and Opera.

In the meantime use Firefox or wait for this issue to be resolved.

@susnux susnux changed the title [Bug]: When drag and drop multiple files, only one is loaded [Bug]: When drag and drop multiple files, only one is loaded [blink engine] Mar 1, 2024
@kayvanaarssen

This comment was marked as spam.

@camouflage81
Copy link

When drag and drop a file, the system no longer checks whether it already exists. The file on the server is simply overwritten.

@susnux susnux added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Mar 17, 2024
@susnux susnux self-assigned this Mar 17, 2024
@susnux susnux moved this to 🏗️ In progress in 📁 Files team Mar 17, 2024
@github-project-automation github-project-automation bot moved this from 🕶️ Design review to 🎉 Done in 🖍 Design team Mar 18, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Mar 18, 2024
@AInteriorB
Copy link

Closed as completed ... with all the good suggestions marked as spam ignored ...

🙄

@susnux
Copy link
Contributor

susnux commented Mar 18, 2024

This issue is about drag-drop only uploading one file and this issue is fixed now :)
Feel free to open new issues with bug reports or feature requests but it makes no sense to put that into a completely unrelated issue report.

@D3nnis3n
Copy link

D3nnis3n commented Mar 23, 2024

This issue is about drag-drop only uploading one file and this issue is fixed now :) Feel free to open new issues with bug reports or feature requests but it makes no sense to put that into a completely unrelated issue report.

This issue is not fixed in 28.0.3, and was about dragging and dropping multiple files, of which only one gets uploaded - which is still the case in 28.0.3:
image

Guess we continue here? #44390

@skjnldsv
Copy link
Member

With 2 clicks you can see that the fix is within 28.0.4
#44273

@SergioRius
Copy link

I'm on 29.0.5 and this issue still reproduces for me on Firefox-based browser (Floorp) and Chrome-based browser (Vivaldi).
I would bet that I didn't happen with the last of 28s.

@susnux
Copy link
Contributor

susnux commented Sep 2, 2024

I'm on 29.0.5 and this issue still reproduces for me on Firefox-based browser (Floorp) and Chrome-based browser (Vivaldi).

29.0.5 with Firefox - can not reproduce drag-and-drop two files and both are uploaded.
Regardless if dropped on drop zone or a folder.

Same with Chromium 128 used with Nextcloud 29.0.5. Try to clear your cache and look in the browser dev tools for error messages.

@SergioRius
Copy link

SergioRius commented Sep 3, 2024

Trying to upload 5 files to a new empty folder.

  1. Five images to upload
    Note: From Linux, KDE Ubuntu to Floop (Firefox)
    image

  2. Dragging to the upload deck
    Note: The folder is contained between a group shared folder.
    image

  3. The following notifications appear: ("File not found" and "File upload success")
    Edit: The error not always appears and seems unrelated.
    image

  4. Only the first image uploaded.
    image

  5. Errors on console.
    image

To me it seems that they all appear after the upload.
I'm investigating the one for duplicated setting, but it's a Vue trace. Anyways I think it could be related to the configuration of PHP OPcache, that I override on ".../nextcloud/php/php-local.ini" (linuxserver docker), but still complains in admin about not being configured above the default.

The upload problem happens with files and folders, independently from it's size. I it always reproduces after the update to 29.x.x

EDIT: Uploading to a non-shared folder shows the same behaviour.

I'm using the linuxserver's docker container. Could it be that the upload depends on an external component that the maintainer may not have upgraded?

@susnux
Copy link
Contributor

susnux commented Sep 3, 2024

@SergioRius could you retry now with 29.0.6 and if that does not work also show your network tab from the dev tools?

@SergioRius
Copy link

SergioRius commented Sep 3, 2024

@SergioRius could you retry now with 29.0.6 and if that does not work also show your network tab from the dev tools?

Thanks for your help, @susnux .
As the new version was published some minutes ago I deployed and did another test with it. Unfortunately it didn't work:
imagen
The file names uploaded are DSC00334.JPG, IMG_20190422_164256.jpg and IMG_20190422_164311.jpg in a new folder at the root.
The previous error I mentioned about a file missing, it's confirmed that it's totally unrelated. I happens sometimes when I enter a folder that has images.
I usually have plenty of errors from preview generator and recognize in the log. Perhaps it has to do with this upload problem? As I see that there's a PG error in the console after the first file is uploaded, and then almost nothing more...

imagen
imagen

I'll disable recognize, PG and try again. If I don't post any results is that I also did fail.

PS: If you need something more advanced, just tell. I'm sw developer (unfortunately not php) and I'll try to give you anything you need.

EDIT: Deactivating previewgenerator and recognize didn't change anything. Only first file processed.
imagen

@susnux
Copy link
Contributor

susnux commented Sep 3, 2024

Those errors are about preview generation and should be unrelated. From the network tab there is also only one PUT. Meaning the upload is either aborted or the browser only passed one file for upload.

Could you please check for debug log messages in the dev tools?

BTW: I had this error once with Firefox - restarting Firefox helped as somehow Firefox was not correctly fetching the dragged files.

@SergioRius
Copy link

SergioRius commented Sep 3, 2024

Could you please check for debug log messages in the dev tools?

You mean the debug console? It's only throwed the error reported before:

A setting with the same name is already registered Settings.js:41:11
    register Settings.js:41
    render main.js:58
    mounted FilesListHeader.vue:41
    VueJS 21
        cn
        $n
        insert
        C
        xi
        _update
        a
        get
        run
        ra
        kn
        vn
    (Asíncrono: promise callback)
        fn
        kn
        ia
        update
        notify
        set
        set value
        set
        Oe
    updateNodes files.ts:77
    E pinia.mjs:1380
    fetchContent FilesList.vue:321
    onUpload FilesList.vue:392
    VueJS 4
        cn
        n
        cn
        $emit
    onUploadCompletion index-DNLyAvkP.mjs:1323
    _notifyAll index-DNLyAvkP.mjs:395
    n index-DNLyAvkP.mjs:666
    add index.js:180
    #x index.js:118
    #L index.js:149
    start index.js:218
    start index-DNLyAvkP.mjs:361
    qt DropService.ts:143
    onDrop DragAndDropNotice.vue:138
    VueJS 27
        cn
        n
        _wrapper
    (Asíncrono: EventListener.handleEvent)
        jr
        kt
        Pr
        _
        h
        xi
        _update
        a
        get
        e
        mount
        $mount
        init
        h
        h
        E
        E
        xi
        _update
        a
        get
        run
        ra
        kn

It would be nice if that error notification function showed the setting key e.name that it's supposedly duplicated.

And there's another error about recommendation not able to load a preview. I suppose bc it's too fast to ask for it and still hasn't been generated.

BTW: I had this error once with Firefox - restarting Firefox helped as somehow Firefox was not correctly fetching the dragged files.

Unfortunately I've even rebooted the computer and made no change.
Anyways, I can drag-n-drop multiple files between folders in dolphin.

EDIT: Same result by dragging from Krusader and no imges, but three txt files.

@Knusper
Copy link

Knusper commented Sep 21, 2024

Just to make some noise, I also have the same issue with Firefox and KDE Dolphin. Drag & Drop of multiple files to other file providers just works - so it must be on nextcloud side...

@SergioRius
Copy link

As a followup, since my last update I've migrated to nextcloud-aio, still at v29.
The problem still persists on Firefox based browsers, but using Vivaldi (Chromium based) I can upload more than one file. The Aio install is one build beyond the docker install, so I don't know if as to do with it working on chrome.

@b-jordanov
Copy link

I’m experiencing the same issue with Firefox and KDE Dolphin. Dragging and dropping multiple files works fine with other file providers, so the problem seems to be on the Nextcloud's side.

@Knusper
Copy link

Knusper commented Oct 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.