[Bug]: Undefined variable $result at /PATH/core/Command/App/Update.php#114 (and #117) #42476
Comments
nursoda
added
0. Needs triage
joshtrichards
added
1. to develop
Fixes #42476 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
|
Proposed fix in #42488. Feedback appreciated if you're able to it. |
|
Thanks for that PR! I cannot test since I have no instance with a pending yet update that doesn't fulfill the NC version requirements. You are aware that it "only" fixes "expected behavior" #2, right? Concerning "expected behavior" #2, I think that an "update all apps" has to be interpreted as "update all apps that are updatable". In that respect, when performing If the command were I see that distinguishing these cases is difficult since I assume that an |
Bug description
Today, on a NC28.0.1 instance I ran
occ app:update --all. It yieldedThat is to be expected. However, with the same timestamp, I also see two additional log entries that I think should not occur:
Steps to reproduce
(correct since there is no NC28 compatible app release yet on apps.nextcloud.com)
occ app:update --allExpected behavior
Installation method
Community Manual installation with Archive
Nextcloud Server version
28
Operating system
Other
PHP engine version
PHP 8.2
Web server
Nginx
Database engine version
MariaDB
Is this bug present after an update or on a fresh install?
Upgraded to a MAJOR version (ex. 22 to 23)
Are you using the Nextcloud Server Encryption module?
None
What user-backends are you using?
Configuration report
{ "system": { "instanceid": "***REMOVED SENSITIVE VALUE***", "passwordsalt": "***REMOVED SENSITIVE VALUE***", "secret": "***REMOVED SENSITIVE VALUE***", "trusted_domains": [ "test.seyfarth.de" ], "datadirectory": "***REMOVED SENSITIVE VALUE***", "dbtype": "mysql", "version": "28.0.1.1", "overwrite.cli.url": "https:\/\/test.seyfarth.de", "dbname": "***REMOVED SENSITIVE VALUE***", "dbhost": "***REMOVED SENSITIVE VALUE***", "dbport": "", "dbtableprefix": "oc_", "mysql.utf8mb4": true, "dbuser": "***REMOVED SENSITIVE VALUE***", "dbpassword": "***REMOVED SENSITIVE VALUE***", "installed": true, "memcache.local": "\\OC\\Memcache\\APCu", "memcache.distributed": "\\OC\\Memcache\\Redis", "memcache.locking": "\\OC\\Memcache\\Redis", "redis": { "host": "***REMOVED SENSITIVE VALUE***", "port": 0, "dbindex": 7, "timeout": 1.5 }, "logtimezone": "Europe\/Berlin", "mail_from_address": "***REMOVED SENSITIVE VALUE***", "mail_smtpmode": "smtp", "mail_domain": "***REMOVED SENSITIVE VALUE***", "mail_smtpsecure": "tls", "mail_sendmailmode": "smtp", "mail_smtphost": "***REMOVED SENSITIVE VALUE***", "mail_smtpport": "25", "trashbin_retention_obligation": "7,30", "versions_retention_obligation": "auto,366", "skeletondirectory": "", "default_language": "de_DE", "default_locale": "de_DE", "default_phone_region": "DE", "theme": "", "loglevel": 2, "simpleSignUpLink.shown": false, "twofactor_enforced": "true", "twofactor_enforced_groups": [ "admin" ], "twofactor_enforced_excluded_groups": [ "2FA-Ausnahme" ], "has_rebuilt_cache": true, "updater.release.channel": "beta", "trusted_proxies": "***REMOVED SENSITIVE VALUE***", "blacklisted_files": [], "htaccess.IgnoreFrontController": true, "maintenance": false, "memories.exiftool_no_local": true, "memories.vod.path": "\/server\/www\/seyfarth\/test\/apps\/memories\/bin-ext\/go-vod-amd64", "memories.vod.ffmpeg": "\/usr\/bin\/ffmpeg", "memories.vod.ffprobe": "\/usr\/bin\/ffprobe" } }List of activated Apps
Nextcloud Signing status
Nextcloud Logs
{"reqId":"44ntbDUgCE6T56vcfZqC","level":3,"time":"2023-12-25T10:18:25+01:00","remoteAddr":"","user":"--","app":"app:update","method":"","url":"--","message":"Failure during update of app \"riotchat\"","userAgent":"--","version":"28.0.1.1","exception":{"Exception":"Exception","Message":"App \"Element for Nextcloud\" cannot be installed because the following dependencies are not fulfilled: Server version 27 or lower is required.","Code":0,"Trace":[{"file":"/PATH/lib/private/legacy/OC_App.php","line":764,"function":"checkAppDependencies","class":"OC_App","type":"::"},{"file":"/PATH/lib/private/Installer.php","line":202,"function":"updateApp","class":"OC_App","type":"::","args":["*** sensitive parameters replaced ***"]},{"file":"/PATH/core/Command/App/Update.php","line":104,"function":"updateAppstoreApp","class":"OC\\Installer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/PATH/3rdparty/symfony/console/Command/Command.php","line":298,"function":"execute","class":"OC\\Core\\Command\\App\\Update","type":"->"},{"file":"/PATH/3rdparty/symfony/console/Application.php","line":1040,"function":"run","class":"Symfony\\Component\\Console\\Command\\Command","type":"->"},{"file":"/PATH/3rdparty/symfony/console/Application.php","line":301,"function":"doRunCommand","class":"Symfony\\Component\\Console\\Application","type":"->"},{"file":"/PATH/3rdparty/symfony/console/Application.php","line":171,"function":"doRun","class":"Symfony\\Component\\Console\\Application","type":"->"},{"file":"/PATH/lib/private/Console/Application.php","line":206,"function":"run","class":"Symfony\\Component\\Console\\Application","type":"->"},{"file":"/PATH/console.php","line":100,"function":"run","class":"OC\\Console\\Application","type":"->"},{"file":"/PATH/occ","line":11,"args":["/PATH/console.php"],"function":"require_once"}],"File":"/PATH/lib/private/legacy/OC_App.php","Line":967,"message":"Failure during update of app \"riotchat\"","exception":{},"CustomMessage":"Failure during update of app \"riotchat\""}} {"reqId":"44ntbDUgCE6T56vcfZqC","level":3,"time":"2023-12-25T10:18:25+01:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Undefined variable $result at /PATH/core/Command/App/Update.php#114","userAgent":"--","version":"28.0.1.1","data":{"app":"PHP"}} {"reqId":"44ntbDUgCE6T56vcfZqC","level":3,"time":"2023-12-25T10:18:25+01:00","remoteAddr":"","user":"--","app":"PHP","method":"","url":"--","message":"Undefined variable $result at /PATH/core/Command/App/Update.php#117","userAgent":"--","version":"28.0.1.1","data":{"app":"PHP"}}Additional info
No response
The text was updated successfully, but these errors were encountered: