[Bug]: Unable to invite guest

[nfebe]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

Can't create guest share.
On attempt the following is thrown Error creating the share: Unknown share type

Steps to reproduce

1. Set up https://github.com/nextcloud/guests/
2. Open the sharing sidebar
3. Enter an email address
4. Click Invite guest
5. Click on "Save share"

Expected behavior

Save share, should successfully register a new share of type guest.

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

[juliusknorr]

My suggestion would be to revert the fix and try to mirror the behaviour we had before 27.1 where share would be created of type USER.

The new sharing flow implementation seems to have left out custom share result handlers. The code is still present in

server/apps/files_sharing/src/components/SharingInput.vue

Line 480 in 1f6101d

if (value.handler) {

but not called at all.

For guest users we should still call the handler so that the guest app can take care of the guest user and share creation.

https://github.com/nextcloud/guests/blob/09bc8db9c148e7be41d16f074bb17d8fb2bcd800/src/main.js#L30-L40

[nfebe]

The handler is still present in the new flow :

server/apps/files_sharing/src/views/SharingDetailsTab.vue

Lines 809 to 814 in 1f6101d

	// handle externalResults from OCA.Sharing.ShareSearch
	if (value.handler) {
	const share = await value.handler(this)
	this.$emit('add:share', new Share(share))
	return true
	}

Rather, what I suspect is that converting the base object to a Share object, drops out the handler

server/apps/files_sharing/src/mixins/ShareDetails.js

Line 40 in 1f6101d

return new Share(share)

So, a way to maintain it, to pass the handler forward is required.

The changes done, would still be nice to have though.

[juliusknorr]

I think we should still call the handlers upfront before triggering the new sharing flow, so that the guest user is already created, iirc @jancborchardt also agreed on that in one of our calls.