Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: PROPFIND on dav returns null instead of 404 #32514

Closed
4 of 8 tasks
Tracked by #669
tobiasKaminsky opened this issue May 20, 2022 · 6 comments · Fixed by #32548 or nextcloud/text#2608
Closed
4 of 8 tasks
Tracked by #669

[Bug]: PROPFIND on dav returns null instead of 404 #32514

tobiasKaminsky opened this issue May 20, 2022 · 6 comments · Fixed by #32548 or nextcloud/text#2608
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug regression

Comments

@tobiasKaminsky
Copy link
Member

⚠️ This issue respects the following points: ⚠️

  • This is a bug, not a question or a configuration/webserver/proxy issue.
  • This issue is not already reported on Github (I've searched it).
  • Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
  • I agree to follow Nextcloud's Code of Conduct.

Bug description

With NC23 this works:

  • create a file
  • do a propfind with comments-unread
  • see 207 multi-part response with oc:comments-unread/ in 404 status part

Now with master it is in 200 status part:
oc:comments-unread</oc:comments-unread>

As Android expects this to be an integer, it is translated to null, which fails.

Steps to reproduce

  • create a file
  • do a propfind with comments-unread

Expected behavior

Same as in NC23: oc:comments-unread/ in 404 status part.

Installation method

Manual installation

Operating system

No response

PHP engine version

No response

Web server

No response

Database engine version

No response

Is this bug present after an update or on a fresh install?

No response

Are you using the Nextcloud Server Encryption module?

No response

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

/

Nextcloud Signing status

/

Nextcloud Logs

/

Additional info

No response

@tobiasKaminsky tobiasKaminsky added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 20, 2022
@nickvergessen nickvergessen changed the title [Bug]: PROPFIND on dav returns null nistead of 404 [Bug]: PROPFIND on dav returns null instead of 404 May 20, 2022
@PVince81
Copy link
Member

without looking at the code, one change I'm aware of is that we touched a lot of code to make it ready for PHP 8.1
so perhaps there might have been some added type safety somewhere that coerced the type in some way ? @come-nc

we also touched a bit of DAV for metadata @CarlSchwan

@tobiasKaminsky
Copy link
Member Author

This also happens for rich-workspaces:
In NC22 it was expected to have this behavior:
// richWorkspace
// == "": no info set -> show button
// == null: disabled on server side -> hide button
// != "": info set -> hide button

Now on master/NC24 it seems that null is returned until user really creates a file / types something.
@CarlSchwan maybe?

@PVince81 PVince81 added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 20, 2022
@PVince81
Copy link
Member

@CarlSchwan please have a look

@CarlSchwan
Copy link
Member

we forgot to backport #32548 😢

@tobiasKaminsky
Copy link
Member Author

$32548 does not fix this.
I tested it with latest master and it still returns null, instead of "".

@CarlSchwan
Copy link
Member

CarlSchwan commented Jun 21, 2022

This is a regression from nextcloud/text@3e40b7b @max-nextcloud

max-nextcloud added a commit to nextcloud/text that referenced this issue Jun 22, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit to nextcloud/text that referenced this issue Jun 22, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit to nextcloud/text that referenced this issue Jun 22, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit to nextcloud/text that referenced this issue Jun 22, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit to nextcloud/text that referenced this issue Jun 22, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
juliusknorr pushed a commit to nextcloud/text that referenced this issue Jul 5, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit to nextcloud/text that referenced this issue Jul 6, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
backportbot-nextcloud bot pushed a commit to nextcloud/text that referenced this issue Jul 6, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit to nextcloud/text that referenced this issue Jul 6, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
nextcloud-command pushed a commit to nextcloud/text that referenced this issue Jul 6, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
juliusknorr pushed a commit to nextcloud/text that referenced this issue Jul 6, 2022
Regression tests for
nextcloud/server#32514 (comment)

Signed-off-by: Max <max@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants