-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images upload from web page is slow because two previews are generated instead of once #16963
Comments
By the way this seems to be a bug: server/lib/private/legacy/image.php Line 884 in 503b9c6
if ($process == false) {
...
imagedestroy($process); <-- $process is a boolean here...
...
} and here too: server/lib/private/legacy/image.php Line 898 in 503b9c6
|
Looks good to me. Mind to create a pull request with your changes?
Mind to have a look at this? This could be the reason for |
MMMhhhh ok, it seems I played a bit with config and issued those ugly things:
I removed those ugly config params, and have no more errors in nextcloud logs. In the end, standard nextcloud config, no errors, but two previews generated instead of only one... |
Signed-off-by: Samuel CHEMLA <chemla.samuel@gmail.com>
If I read correctly was this fixed with #16964 -> closing. |
After reading a bit more, I think this is not a bug but just the way how previews work in Nextcloud: the big thumbnail is for viewing it in the viewer app and the small for the list view. So not a bug but expected. -> closing. |
Steps to reproduce
Expected behaviour
There should be only one preview file on the server side
Actual behaviour
On the server side, two preview files are generated:
* 256-256-crop.jpg
* 5984-3376-max.jpg
When you upload a file from a web browser, you are in the file list, therefore only one small preview is required.
The bigger one is not (yet) required, and should either not be generated, or delayed for future generation.
This yields to very slow file upload, and if you upload many pictures, it will flood your server (the preview request takes around 10s on a dedicated i3-4020Y CPU @ 1.50GHz 4gb ram).
Server configuration
Operating system: ubuntu 18.04
Web server: apache 2.4 with fpm configuration
Database: mariadb 10.1
PHP version: 7.2
Nextcloud version: 16.0.4
Updated from an older Nextcloud/ownCloud or fresh install: Updated from 16.0.2, then 16.0.3
Where did you install Nextcloud from: official nextcloud release from github
Signing status:
Signing status
List of activated apps:
App list
Nextcloud configuration:
Config report
Are you using external storage, if yes which one: cifs
Are you using encryption: no
Are you using an external user-backend, if yes which one: no
Client configuration
Browser: Chromium 76
Operating system: Ubuntu 18.04
Logs
Web server error log
Web server error log
Nextcloud log (data/nextcloud.log)
Nextcloud log
Browser log
Browser log
The text was updated successfully, but these errors were encountered: