Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache::getId should return as int (not string) #16684

Closed
patricksebastien opened this issue Aug 7, 2019 · 0 comments · Fixed by #16686
Closed

Cache::getId should return as int (not string) #16684

patricksebastien opened this issue Aug 7, 2019 · 0 comments · Fixed by #16686
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug

Comments

@patricksebastien
Copy link

patricksebastien commented Aug 7, 2019 •
edited
Loading

Steps to reproduce

  1. Using the groupfolder permission occ command:
    occ groupfolders:permissions 4 --user User / -- +write

Expected behaviour

Setting the permission for the folder without error.

Actual behaviour

TypeError: Argument 2 passed to OCA\GroupFolders\ACL\Rule::__construct() must be of the type integer, string given, called in /var/www/html/nextcloud/apps/groupfolders/lib/Command/ACL.php on line 185 and defined in /var/www/html/nextcloud/apps/groupfolders/lib/ACL/Rule.php:48

Solution

Forcing intval() on Cache::getId
https://github.com/nextcloud/server/blob/master/lib/private/Files/Cache/Cache.php#L419

Groupfolder issue:

nextcloud/groupfolders#470

Server configuration

Operating system:
Ubuntu

Web server:
Nginx

Database:
Mysql

PHP version:
7.2

Nextcloud version:
16.0.4
@patricksebastien patricksebastien added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Aug 7, 2019
rullzer added a commit that referenced this issue Aug 7, 2019
@rullzer
Properly return an int in the getId function of the cache
650927a 
fixes #16684

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer mentioned this issue Aug 7, 2019
Merged
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 8, 2019
@rullzer
Properly return an int in the getId function of the cache
55ad6c1 
fixes #16684

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
backportbot-nextcloud bot pushed a commit that referenced this issue Aug 8, 2019
@rullzer
Properly return an int in the getId function of the cache
337aa1c 
fixes #16684

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
compagnon pushed a commit to compagnon/nextcloud-server that referenced this issue Aug 22, 2019
@rullzer @compagnon
Properly return an int in the getId function of the cache
d4e8056 
fixes nextcloud#16684

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Properly return an int in the getId function of the cache nextcloud/server
1 participant
@patricksebastien