Deprecated php warning

[xf-]

Steps to reproduce

1. Use nextcloud

Expected behaviour

No Warning/log entry

Actual behaviour

Log entry on every page

Server configuration

Operating system: Debian stretch

Web server: nginx

Database: mariadb

PHP version: 7.3.0 Beta2

Nextcloud version: (see Nextcloud admin page) 14 RC 1

Logs

Nextcloud log (data/nextcloud.log)

Nextcloud log

filter_var(): explicit use of FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED is deprecated at 

---

PS: PHP 7.3 works really well & fast!

[nextcloud-bot]

GitMate.io thinks possibly related issues are #8265 (php/mcrypt has been deprecated), #5917 (Warning: PHP Opcache not properly configured), #5044 (Security & setup warnings > Which php.ini to edit?), #6784 (Php error?), and #10744 (Update help.php).

[patschi]

I was able to see same behavior with 14 RC2 as well. Apparently both flags FILTER_FLAG_SCHEME_REQUIRED and FILTER_FLAG_HOST_REQUIRED are now deprecated starting with PHP 7.3 and are implied in FILTER_VALIDATE_URL anyway. So it should be save just removing the flags from filter_var() calls.

Some resources to check:

• php/php-src@79a27cc
• https://wiki.php.net/rfc/deprecations_php_7_3#filter_flag_scheme_required_and_filter_flag_host_required
• http://php.net/manual/en/filter.filters.validate.php