Skip to content

Commit

Permalink
feat(Navigation): enable target blank on Administration settings
Browse files Browse the repository at this point in the history
Signed-off-by: Fitrah Munir <fitrahmunir@outlook.com>
  • Loading branch information
fitrahmunir committed Mar 12, 2024
1 parent 0f8695d commit ebc2167
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions lib/private/NavigationManager.php
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ private function init() {
'id' => 'admin_settings',
'order' => 4,
'href' => $this->urlGenerator->linkToRoute('settings.AdminSettings.index', ['section' => 'overview']),
'target' => '_blank',
'name' => $l->t('Administration settings'),
'icon' => $this->urlGenerator->imagePath('settings', 'admin.svg'),
]);
Expand Down
3 changes: 2 additions & 1 deletion tests/lib/NavigationManagerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,8 @@ public function providesNavigationConfig() {
'active' => false,
'type' => 'settings',
'classes' => '',
'unread' => 0
'unread' => 0,
'target' => '_blank',
]
];

Expand Down

0 comments on commit ebc2167

Please sign in to comment.