fix: Swap method and uri parameter in request to match upstream order

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
nextcloud · Mar 7, 2024 · 9065c29 · 9065c29
1 parent 583f640
commit 9065c29
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/private/Http/Client/Client.php b/lib/private/Http/Client/Client.php
@@ -427,8 +427,8 @@ public function getResponseFromThrowable(\Throwable $e): IResponse {
 	/**
 	 * Sends a HTTP request
 	 *
-	 * @param string $uri
 	 * @param string $method The HTTP method to use
+	 * @param string $uri
 	 * @param array $options Array such as
 	 *              'query' => [
 	 *                  'field' => 'abc',
@@ -454,7 +454,7 @@ public function getResponseFromThrowable(\Throwable $e): IResponse {
 	 * @return IResponse
 	 * @throws \Exception If the request could not get completed
 	 */
-	public function request(string $uri, string $method, array $options = []): IResponse {
+	public function request(string $method, string $uri, array $options = []): IResponse {
 		$this->preventLocalAddress($uri, $options);
 		$response = $this->client->request($method, $uri, $this->buildRequestOptions($options));
 		$isStream = isset($options['stream']) && $options['stream'];

diff --git a/lib/public/Http/Client/IClient.php b/lib/public/Http/Client/IClient.php
@@ -219,8 +219,8 @@ public function getResponseFromThrowable(\Throwable $e): IResponse;
 
 	/**
 	 * Sends a HTTP request
-	 * @param string $uri
 	 * @param string $method The HTTP method to use
+	 * @param string $uri
 	 * @param array $options Array such as
 	 *              'query' => [
 	 *                  'field' => 'abc',
@@ -246,7 +246,7 @@ public function getResponseFromThrowable(\Throwable $e): IResponse;
 	 * @throws \Exception If the request could not get completed
 	 * @since 29.0.0
 	 */
-	public function request(string $uri, string $method, array $options = []): IResponse;
+	public function request(string $method, string $uri, array $options = []): IResponse;
 
 	/**
 	 * Sends an asynchronous GET request