Merge pull request #47149 from nextcloud/fix/disable-tags-editing

fix(files): Disable tags editing for shared files/folders with view only permission
nextcloud · Aug 9, 2024 · 81b01c2 · 81b01c2
2 parents dda6dd0 + de769f0
commit 81b01c2
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 6 deletions.
diff --git a/apps/files/src/services/FileInfo.js b/apps/files/src/services/FileInfo.js
@@ -24,6 +24,7 @@ export default async function(url) {
 	// TODO remove when no more legacy backbone is used
 	fileInfo.get = (key) => fileInfo[key]
 	fileInfo.isDirectory = () => fileInfo.mimetype === 'httpd/unix-directory'
+	fileInfo.canEdit = () => Boolean(fileInfo.permissions & OC.PERMISSION_UPDATE)
 
 	return fileInfo
 }
diff --git a/apps/files/src/views/Sidebar.vue b/apps/files/src/views/Sidebar.vue
@@ -30,6 +30,7 @@
 			<div class="sidebar__description">
 				<SystemTags v-if="isSystemTagsEnabled && showTagsDefault"
 					v-show="showTags"
+					:disabled="!fileInfo?.canEdit()"
 					:file-id="fileInfo.id"
 					@has-tags="value => showTags = value" />
 				<LegacyView v-for="view in views"

diff --git a/apps/systemtags/src/components/SystemTags.vue b/apps/systemtags/src/components/SystemTags.vue
@@ -15,6 +15,7 @@
 				:options="sortedTags"
 				:value="selectedTags"
 				:create-option="createOption"
+				:disabled="disabled"
 				:taggable="true"
 				:passthru="true"
 				:fetch-tags="false"
@@ -65,6 +66,10 @@ export default Vue.extend({
 			type: Number,
 			required: true,
 		},
+		disabled: {
+			type: Boolean,
+			default: false,
+		},
 	},
 
 	data() {

diff --git a/dist/core-common.js b/dist/core-common.js
diff --git a/dist/core-common.js.map b/dist/core-common.js.map
diff --git a/dist/files-sidebar.js b/dist/files-sidebar.js
diff --git a/dist/files-sidebar.js.map b/dist/files-sidebar.js.map