Merge pull request #46321 from nextcloud/fix/46195/feedback-no-read-p…

…erms fix(SharingDetailsView): Prevent illegal unselection of read permissions
nextcloud · Jul 8, 2024 · 7b60b98 · 7b60b98
2 parents 9b2d195 + 5bb36dc
commit 7b60b98
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 8 deletions.
diff --git a/apps/files_sharing/src/views/SharingDetailsTab.vue b/apps/files_sharing/src/views/SharingDetailsTab.vue
@@ -180,7 +180,7 @@
 						{{ t('files_sharing', 'Custom permissions') }}
 					</NcCheckboxRadioSwitch>
 					<section v-if="setCustomPermissions" class="custom-permissions-group">
-						<NcCheckboxRadioSwitch :disabled="!allowsFileDrop && share.type === SHARE_TYPES.SHARE_TYPE_LINK"
+						<NcCheckboxRadioSwitch :disabled="!canRemoveReadPermission"
 							:checked.sync="hasRead"
 							data-cy-files-sharing-share-permissions-checkbox="read">
 							{{ t('files_sharing', 'Read') }}
@@ -602,6 +602,9 @@ export default {
 			// allowed to revoke it too (but not to grant it again).
 			return (this.fileInfo.canDownload() || this.canDownload)
 		},
+		canRemoveReadPermission() {
+			return this.allowsFileDrop && this.share.type === this.SHARE_TYPES.SHARE_TYPE_LINK
+		},
 		// if newPassword exists, but is empty, it means
 		// the user deleted the original password
 		hasUnsavedPassword() {
@@ -822,6 +825,10 @@ export default {
 					this.setCustomPermissions = true
 				}
 			}
+			// Read permission required for share creation
+			if (!this.canRemoveReadPermission) {
+				this.hasRead = true
+			}
 		},
 		handleCustomPermissions() {
 			if (!this.isNewShare && (this.hasCustomPermissions || this.share.setCustomPermissions)) {

diff --git a/dist/1200-1200.js.map b/dist/1200-1200.js.map
diff --git a/dist/1200-1200.js.map.license b/dist/1200-1200.js.map.license
diff --git a/dist/1200-1200.js → dist/7885-7885.js b/dist/1200-1200.js → dist/7885-7885.js
diff --git a/dist/1200-1200.js.license → dist/7885-7885.js.license b/dist/1200-1200.js.license → dist/7885-7885.js.license
diff --git a/dist/7885-7885.js.map b/dist/7885-7885.js.map
diff --git a/dist/7885-7885.js.map.license b/dist/7885-7885.js.map.license
@@ -0,0 +1 @@
+7885-7885.js.license
diff --git a/dist/files_sharing-files_sharing_tab.js b/dist/files_sharing-files_sharing_tab.js
diff --git a/dist/files_sharing-files_sharing_tab.js.map b/dist/files_sharing-files_sharing_tab.js.map