Skip to content

Commit

Permalink
Do not invalidate main token on OAuth
Browse files Browse the repository at this point in the history
Fixes #10584

We deleted the main token when using the login flow else mutliple tokens
would show up for a single user.

However in the case of OAuth this is perfectly fine as the
authentication happens really in your browser:

1. You are already logged in, no need to log you out
2. You are not logged in yet, but since you log in into the exact same
browser the expected behavior is to stay logged in.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
  • Loading branch information
rullzer committed Sep 6, 2018
1 parent 1b35dc1 commit 5485932
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions core/Controller/ClientFlowLoginController.php
Original file line number Diff line number Diff line change
Expand Up @@ -366,10 +366,10 @@ public function generateAppPassword($stateToken,

$serverPath = $protocol . "://" . $this->request->getServerHost() . $serverPostfix;
$redirectUri = 'nc://login/server:' . $serverPath . '&user:' . urlencode($loginName) . '&password:' . urlencode($token);
}

// Clear the token from the login here
$this->tokenProvider->invalidateToken($sessionId);
// Clear the token from the login here
$this->tokenProvider->invalidateToken($sessionId);
}

return new Http\RedirectResponse($redirectUri);
}
Expand Down

0 comments on commit 5485932

Please sign in to comment.