Merge pull request #38291 from nextcloud/fix-loading-themed-logo

fix loading custom logo image
nextcloud · May 22, 2023 · 5479eb3 · 5479eb3
2 parents b313e2a + 51984dc
commit 5479eb3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/apps/theming/lib/Util.php b/apps/theming/lib/Util.php
@@ -190,7 +190,7 @@ public function getAppIcon($app) {
 		if ($this->config->getAppValue('theming', 'logoMime', '') !== '') {
 			$logoFile = null;
 			try {
-				$folder = $this->appData->getFolder('images');
+				$folder = $this->appData->getFolder('global/images');
 				return $folder->getFile('logo');
 			} catch (NotFoundException $e) {
 			}

diff --git a/apps/theming/tests/IconBuilderTest.php b/apps/theming/tests/IconBuilderTest.php
@@ -103,7 +103,7 @@ public function testRenderAppIcon($app, $color, $file) {
 			->willReturn($color);
 		$this->appData->expects($this->once())
 			->method('getFolder')
-			->with('images')
+			->with('global/images')
 			->willThrowException(new NotFoundException());
 
 		$expectedIcon = new \Imagick(realpath(dirname(__FILE__)). "/data/" . $file);
@@ -132,7 +132,7 @@ public function testGetTouchIcon($app, $color, $file) {
 			->willReturn($color);
 		$this->appData->expects($this->once())
 			->method('getFolder')
-			->with('images')
+			->with('global/images')
 			->willThrowException(new NotFoundException());
 
 		$expectedIcon = new \Imagick(realpath(dirname(__FILE__)). "/data/" . $file);
@@ -165,7 +165,7 @@ public function testGetFavicon($app, $color, $file) {
 			->willReturn($color);
 		$this->appData->expects($this->once())
 			->method('getFolder')
-			->with('images')
+			->with('global/images')
 			->willThrowException(new NotFoundException());
 
 		$expectedIcon = new \Imagick(realpath(dirname(__FILE__)). "/data/" . $file);

diff --git a/apps/theming/tests/UtilTest.php b/apps/theming/tests/UtilTest.php
@@ -153,7 +153,7 @@ public function testGenerateRadioButtonBlack() {
 	public function testGetAppIcon($app, $expected) {
 		$this->appData->expects($this->any())
 			->method('getFolder')
-			->with('images')
+			->with('global/images')
 			->willThrowException(new NotFoundException());
 		$this->appManager->expects($this->once())
 			->method('getAppPath')
@@ -180,7 +180,7 @@ public function testGetAppIconThemed() {
 			->willReturn($file);
 		$this->appData->expects($this->once())
 			->method('getFolder')
-			->with('images')
+			->with('global/images')
 			->willReturn($folder);
 		$icon = $this->util->getAppIcon('noapplikethis');
 		$this->assertEquals($file, $icon);