Skip to content

Commit

Permalink
getStorage before remove
Browse files Browse the repository at this point in the history
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
  • Loading branch information
ArtificialOwl authored and backportbot-nextcloud[bot] committed Jul 13, 2023
1 parent eae4a1e commit 513c243
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions apps/files_external/lib/Service/UserStoragesService.php
Original file line number Diff line number Diff line change
Expand Up @@ -143,4 +143,10 @@ public function getVisibilityType() {
protected function isApplicable(StorageConfig $config) {
return ($config->getApplicableUsers() === [$this->getUser()->getUID()]) && $config->getType() === StorageConfig::MOUNT_TYPE_PERSONAl;
}

public function removeStorage($id) {

Check notice

Code scanning / Psalm

MissingReturnType Note

Method OCA\Files_External\Service\UserStoragesService::removeStorage does not have a return type, expecting void
// verify ownership through $this->isApplicable() and otherwise throws an exception
$this->getStorage($id);
parent::removeStorage($id);
}
}

0 comments on commit 513c243

Please sign in to comment.