fixup! fix: Only apply cast if needed when searching users for value

nextcloud · Nov 30, 2023 · 381db45 · 381db45
1 parent 6564c25
commit 381db45
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/lib/private/AllConfig.php b/lib/private/AllConfig.php
@@ -32,6 +32,7 @@
  */
 namespace OC;
 
+use Doctrine\DBAL\Platforms\OraclePlatform;
 use OCP\Cache\CappedMemoryCache;
 use OCP\DB\QueryBuilder\IQueryBuilder;
 use OCP\IConfig;
@@ -490,7 +491,7 @@ public function getUsersForUserValue($appName, $key, $value) {
 		$this->fixDIInit();
 
 		$qb = $this->connection->getQueryBuilder();
-		$configValueColumn = $this->getSystemValue('dbtype', 'sqlite') === 'oci'
+		$configValueColumn = ($this->connection->getDatabasePlatform() instanceof OraclePlatform)
 			? $qb->expr()->castColumn('configvalue', IQueryBuilder::PARAM_STR)
 			: 'configvalue';
 		$result = $qb->select('userid')
@@ -529,7 +530,7 @@ public function getUsersForUserValueCaseInsensitive($appName, $key, $value) {
 		}
 
 		$qb = $this->connection->getQueryBuilder();
-		$configValueColumn = $this->getSystemValue('dbtype', 'sqlite') === 'oci'
+		$configValueColumn = ($this->connection->getDatabasePlatform() instanceof OraclePlatform)
 			? $qb->expr()->castColumn('configvalue', IQueryBuilder::PARAM_STR)
 			: 'configvalue';