Skip to content

Commit

Permalink
Fix a case where "password_by_talk" was not a boolean (e.g. null or "…
Browse files Browse the repository at this point in the history
…0") and actively cast it to a boolean

This was the error message that we have seen:

```
Argument 1 passed to OC\\Share20\\Share::setSendPasswordByTalk() must be of the type boolean, null given, called in apps/sharebymail/lib/ShareByMailProvider.php on line 981
```

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
  • Loading branch information
MorrisJobke committed Oct 12, 2018
1 parent 85694c6 commit 24a2107
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion apps/sharebymail/lib/ShareByMailProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -980,7 +980,7 @@ protected function createShareObject($data) {
$share->setShareTime($shareTime);
$share->setSharedWith($data['share_with']);
$share->setPassword($data['password']);
$share->setSendPasswordByTalk($data['password_by_talk']);
$share->setSendPasswordByTalk((bool)$data['password_by_talk']);

if ($data['uid_initiator'] !== null) {
$share->setShareOwner($data['uid_owner']);
Expand Down

0 comments on commit 24a2107

Please sign in to comment.