Ignore deactivated users in collaborators user search plugin

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
nextcloud · Aug 6, 2018 · 03f1fef · 03f1fef
1 parent a311798
commit 03f1fef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/lib/private/Collaboration/Collaborators/UserPlugin.php b/lib/private/Collaboration/Collaborators/UserPlugin.php
@@ -79,7 +79,9 @@ public function search($search, $limit, $offset, ISearchResult $searchResult) {
 			$usersTmp = $this->userManager->searchDisplayName($search, $limit, $offset);
 
 			foreach ($usersTmp as $user) {
-				$users[$user->getUID()] = $user->getDisplayName();
+				if ($user->isEnabled()) { // Don't keep deactivated users
+					$users[$user->getUID()] = $user->getDisplayName();
+				}
 			}
 		}
 

diff --git a/tests/lib/Collaboration/Collaborators/UserPluginTest.php b/tests/lib/Collaboration/Collaborators/UserPluginTest.php
@@ -89,7 +89,7 @@ public function instantiatePlugin() {
 		);
 	}
 
-	public function getUserMock($uid, $displayName) {
+	public function getUserMock($uid, $displayName, $enabled = true) {
 		$user = $this->createMock(IUser::class);
 
 		$user->expects($this->any())
@@ -100,6 +100,10 @@ public function getUserMock($uid, $displayName) {
 			->method('getDisplayName')
 			->willReturn($displayName);
 
+		$user->expects($this->any())
+			->method('isEnabled')
+			->willReturn($enabled);
+
 		return $user;
 	}