Refactor building of the checkFileInfo response for cleaner code #2093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
juliushaertl
force-pushed
the
techdebt/clean-checkfileinfo
branch
from
1b6a580
to
28f4ec8
Compare
juliushaertl
force-pushed
the
techdebt/clean-checkfileinfo
branch
from
28f4ec8
to
b9dde19
Compare
juliushaertl
force-pushed
the
techdebt/clean-checkfileinfo
branch
from
b9dde19
to
c6111f2
Compare
juliushaertl
force-pushed
the
techdebt/clean-checkfileinfo
branch
from
c6111f2
to
1c01265
Compare
juliushaertl
force-pushed
the
techdebt/clean-checkfileinfo
branch
2 times, most recently
from
93ccd9f
to
6de1cc8
Compare
…uests Signed-off-by: Julius Härtl <jus@bitgrid.net> Refactor checkFileInfo response building Signed-off-by: Julius Härtl <jus@bitgrid.net> Add Watermark tests Signed-off-by: Julius Härtl <jus@bitgrid.net> Keep older php version supported Signed-off-by: Julius Härtl <jus@bitgrid.net> Stick to the actual user id when available Signed-off-by: Julius Härtl <jus@bitgrid.net> Make psalm happy again Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
techdebt/clean-checkfileinfo
branch
from
6de1cc8
to
f527b51
Compare
juliushaertl
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring that has been lying around for quite some time, mainly to make the checkFileInfo response building a bit more split to logical parts.