switch index to ocs

[tobiasKaminsky]

Fix #828

• webfrontend generates url with "index.php" and thus does not work.

[ChristophWurst]

Dear @tobiasKaminsky,
Thank you very much for the contribution.

This seems to convert the internal API of the app to a public API. To meet the standards of a public API, there has to be documentation about it in the developer documentation of Nextcloud. There are two options for an OCS documentation

1. Manually document the endpoints.
2. Use the OpenAPI generator to auto-generate a machine-readable metadata file.

Please note that once the API is public, it can no longer change in breaking ways for one year.

[ChristophWurst]

Please also see #458. I think the two PRs have the same goal.

[provokateurin]

While you're on this anyway, how about adding https://github.com/nextcloud/openapi-extractor support?
Given the small API surface it shouldn't take much time, but I can also do that for you if you want.

[tobiasKaminsky]

Given the small API surface it shouldn't take much time, but I can also do that for you if you want.

That would be wonderful 💙

[provokateurin]

I tried to keep the changes as minimal as possible. Another good cleanup would be to migrate the annotations and routes to attributes.

[provokateurin]

Meh more things to fix

[provokateurin]

OCI test fails are unrelated, the container image that is used no longer works.
Maintainers should switch to the phpunit templates from the org.

[ChristophWurst]

Does this API match https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-recommendations-api.html? These docs were merged prematurely before the integration of #458.

[provokateurin]

Yes it matches the docs, at least if I understand them correctly.

[provokateurin]

/compile

[Pytal]

OCI test fails are unrelated, the container image that is used no longer works. Maintainers should switch to the phpunit templates from the org.

Done #834

Resolved