fix(psalm): Enable OpenAPI rules

Signed-off-by: provokateurin <kate@provokateurin.de>

lib/Service/RecommendationService.php

@@ -36,9 +36,9 @@ public function __construct(RecentlyCommentedFilesSource $recentlyCommented,
 	}
 
 	/**
-	 * @param IRecommendation[] $recommendations
+	 * @param list<IRecommendation> $recommendations
 	 *
-	 * @return IRecommendation[]
+	 * @return list<IRecommendation>
 	 */
 	private function sortRecommendations(array $recommendations): array {
 		usort($recommendations, function (IRecommendation $a, IRecommendation $b) {
@@ -49,9 +49,9 @@ private function sortRecommendations(array $recommendations): array {
 	}
 
 	/**
-	 * @param IRecommendation[] $recommendations
+	 * @param list<IRecommendation> $recommendations
 	 *
-	 * @return IRecommendation[]
+	 * @return list<IRecommendation>
 	 */
 	private function addPreviews(array $recommendations): array {
 		foreach ($recommendations as $recommendation) {
@@ -65,7 +65,7 @@ private function addPreviews(array $recommendations): array {
 	/**
 	 * @param IUser $user
 	 *
-	 * @return IRecommendation[]
+	 * @return list<IRecommendation>
 	 */
 	public function getRecommendations(IUser $user, int $max = self::MAX_RECOMMENDATIONS): array {
 		$all = array_reduce($this->sources, function (array $carry, IRecommendationSource $source) use ($user) {
@@ -84,9 +84,9 @@ public function getRecommendations(IUser $user, int $max = self::MAX_RECOMMENDAT
 	 * The first (most recent) recommendation wins, hence eventually show its
 	 * recommendation reason
 	 *
-	 * @param IRecommendation[] $recommendations
+	 * @param list<IRecommendation> $recommendations
 	 * @param int $max
-	 * @return IRecommendation[]
+	 * @return list<IRecommendation>
 	 */
 	private function getDeduplicatedSlice(array $recommendations, int $max): array {
 		$picks = [];

psalm.xml

@@ -19,4 +19,10 @@
 	<extraFiles>
 		<directory name="vendor" />
 	</extraFiles>
+	<issueHandlers>
+		<LessSpecificReturnStatement errorLevel="error"/>
+		<LessSpecificReturnType errorLevel="error"/>
+		<LessSpecificImplementedReturnType errorLevel="error"/>
+		<MoreSpecificReturnType errorLevel="error"/>
+	</issueHandlers>
 </psalm>