Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add always visible new album labels #1771

Merged
merged 1 commit into from
May 5, 2023
Merged

Add always visible new album labels #1771

merged 1 commit into from
May 5, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented May 4, 2023 •
edited
Loading

Before After
image image

@Pytal Pytal added 3. to review Waiting for reviews accessibility labels May 4, 2023
@Pytal Pytal added this to the Nextcloud 27 milestone May 4, 2023
@Pytal Pytal self-assigned this May 4, 2023
@Pytal
Copy link
Member Author

Pytal commented May 4, 2023

/compile amend /

@Pytal Pytal mentioned this pull request May 4, 2023
Closed
1 task
szaimen
szaimen approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

artonge
artonge requested changes May 4, 2023
View reviewed changes
Copy link
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you align the MapMarker icon? Either with the text or the input field.

@Pytal Pytal force-pushed the enh/a11y-modal-label branch from 9744d84 to 8c481ac Compare May 5, 2023 01:35
@Pytal
Copy link
Member Author

Pytal commented May 5, 2023

/compile amend /

@Pytal Pytal requested a review from artonge May 5, 2023 01:37
@Pytal @nextcloud-command
Add always visible new album labels
148a58e 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit 55f76c9 into master May 5, 2023
@artonge artonge deleted the enh/a11y-modal-label branch May 5, 2023 06:20
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 5, 2023
This was referenced May 9, 2023
Closed
Merged
@Pytal Pytal mentioned this pull request Mar 7, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@artonge artonge artonge approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @artonge @szaimen