Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up to broad rename from location to place #1657

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Tidy up to broad rename from location to place #1657

merged 1 commit into from
Mar 1, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Feb 27, 2023 •
edited
Loading

After #1334

@artonge artonge self-assigned this Feb 27, 2023
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews php PHP related ticket javascript Javascript related ticket technical debt Technical issue labels Feb 27, 2023
@artonge artonge added this to the Nextcloud 26 milestone Feb 27, 2023
@artonge artonge mentioned this pull request Feb 27, 2023
Merged
@artonge artonge enabled auto-merge February 27, 2023 12:27
@artonge artonge requested a review from skjnldsv February 28, 2023 09:41
@artonge
Tidy up to broad rename from location to place
afb22c9 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/rename_to_place branch from f7777f8 to afb22c9 Compare February 28, 2023 10:16
@artonge artonge merged commit 0b5d88b into master Mar 1, 2023
@artonge artonge deleted the artonge/fix/rename_to_place branch March 1, 2023 09:06
skjnldsv
skjnldsv reviewed Mar 1, 2023
View reviewed changes
lib/Sabre/PropFindPlugin.php
@@ -167,8 +167,8 @@ public function propFind(PropFind $propFind, INode $node): void {
public function handleUpdateProperties($path, PropPatch $propPatch): void {
$node = $this->tree->getNodeForPath($path);
if ($node instanceof AlbumRoot) {
$propPatch->handle(self::LOCATION_PROPERTYNAME, function ($place) use ($node) {
$this->albumMapper->setLocation($node->getAlbum()->getAlbum()->getId(), $place);
$propPatch->handle(self::LOCATION_PROPERTYNAME, function ($location) use ($node) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no front change for the dav property, was it still using the old nc:location ?
@artonge

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes,

photos/src/services/Albums.js

Line 55 in afb22c9

<nc:location />

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, wanted to double check :)

@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket php PHP related ticket technical debt Technical issue
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @skjnldsv