fix(tags performance): Cache tag counts on server and load them using initial state #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport e77a438 to stable25 |
backportbot-nextcloud
bot
added
the
backport-request
skjnldsv
added
enhancement
artonge
reviewed
Jan 25, 2023
artonge
approved these changes
Jan 30, 2023
|
/backport e77a438,7284865,b2ada05 to stable25 |
… initial state ... and only fetch file lists when the corresponding tag is visible Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com> Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/tags-perf
branch
from
b2ada05
to
055b2d7
Compare
|
/backport 8ba4c1e,ba7998f,055b2d7 to stable25 |
marcelklehr
force-pushed
the
fix/tags-perf
branch
from
055b2d7
to
62e1041
Compare
|
/backport 8ba4c1,ba7998f,62e1041 to stable25 |
|
/compile |
… initial state ... and only fetch file lists when the corresponding tag is visible Signed-off-by: Marcel Klehr <mklehr@gmx.net>
marcelklehr
force-pushed
the
fix/tags-perf
branch
from
54f6e81
to
dee1b27
Compare
|
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
|
The backport to stable25 failed. Please do this backport manually. |
|
/backport 8ba4c1e,ba7998f05543afa78f87600b8b781bf08b5a8389,dee1b276b29a64a4c2dfbe07ef4467a809203a7f to stable25 |
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and only fetch file lists when the corresponding tag is visible
This should greatly improves UX and performance of the tags view. Before, the popular tags would continuously jump around for dozens of seconds while the tag counts were being loaded from the server.