Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DAV endpoint for location grouping #1335

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Add DAV endpoint for location grouping #1335

merged 1 commit into from
Feb 24, 2023

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Oct 13, 2022 •
edited
Loading

Needs: #1310

@artonge artonge added enhancement New feature or request 2. developing Work in progress labels Oct 13, 2022
@artonge artonge added this to the Nextcloud 26 milestone Oct 13, 2022
@artonge artonge self-assigned this Oct 13, 2022
@artonge
Copy link
Collaborator Author

artonge commented Oct 13, 2022

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 13, 2022
@artonge artonge force-pushed the artonge/feat/reverse_geocoding_cli branch 8 times, most recently from 2d310e1 to 0063898 Compare October 17, 2022 14:30
@artonge artonge force-pushed the artonge/feat/reverse_geocoding_cli branch 7 times, most recently from 9256a96 to ca44678 Compare October 25, 2022 16:20
@artonge artonge force-pushed the artonge/feat/location_dav_endpoint branch 2 times, most recently from dceccde to 218b33d Compare October 25, 2022 16:27
@artonge artonge force-pushed the artonge/feat/reverse_geocoding_cli branch 2 times, most recently from 187a548 to c091c92 Compare October 26, 2022 09:10
@artonge artonge force-pushed the artonge/feat/location_dav_endpoint branch 3 times, most recently from 4d52cba to a7cbc75 Compare October 26, 2022 09:23
@artonge artonge force-pushed the artonge/feat/reverse_geocoding_cli branch from c091c92 to c5c257d Compare October 26, 2022 09:24
@artonge artonge force-pushed the artonge/feat/location_dav_endpoint branch from a7cbc75 to 351a796 Compare October 26, 2022 09:25
@artonge artonge force-pushed the artonge/feat/reverse_geocoding_cli branch 5 times, most recently from 24dda33 to d94f30c Compare February 22, 2023 14:47
Base automatically changed from artonge/feat/reverse_geocoding_cli to master February 22, 2023 16:30
@artonge artonge force-pushed the artonge/feat/location_dav_endpoint branch 3 times, most recently from bc5ceb1 to 43a965d Compare February 22, 2023 16:43
artonge
artonge commented Feb 22, 2023
View reviewed changes
appinfo/info.xml
@@ -41,7 +41,7 @@
<collection>OCA\Photos\Sabre\PublicRootCollection</collection>
</collections>
<plugins>
<plugin>OCA\Photos\Sabre\Album\PropFindPlugin</plugin>
<plugin>OCA\Photos\Sabre\PropFindPlugin</plugin>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review hint: moved as it is not restricted to albums.

@artonge artonge requested review from come-nc, a team, ArtificialOwl and blizzz and removed request for a team February 22, 2023 16:48
@artonge artonge force-pushed the artonge/feat/location_dav_endpoint branch from 43a965d to 77fda9a Compare February 22, 2023 16:53
come-nc
come-nc reviewed Feb 23, 2023
View reviewed changes
lib/Sabre/Album/AlbumPhoto.php Show resolved Hide resolved
lib/Sabre/Location/LocationPhoto.php Outdated Show resolved Hide resolved
lib/Sabre/Location/LocationRoot.php Outdated Show resolved Hide resolved
lib/Sabre/Location/LocationsHome.php Outdated Show resolved Hide resolved
lib/Sabre/Location/LocationsHome.php Show resolved Hide resolved
lib/Sabre/PropFindPlugin.php Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@artonge
Add DAV endpoint for location grouping
5bd766c 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/location_dav_endpoint branch from 0749728 to 5bd766c Compare February 23, 2023 17:32
@skjnldsv skjnldsv merged commit 680bbff into master Feb 24, 2023
@skjnldsv skjnldsv deleted the artonge/feat/location_dav_endpoint branch February 24, 2023 07:26
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Feb 24, 2023
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

This was referenced Feb 24, 2023
Merged
Closed
@skjnldsv skjnldsv removed the backport-request Pending backport by the backport-bot label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees

@artonge artonge

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @skjnldsv @come-nc