Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HeaderNavigation to have sticky header #1274

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Use HeaderNavigation to have sticky header #1274

merged 1 commit into from
Sep 20, 2022

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 20, 2022 •
edited
Loading

+ Restore route titles

@artonge
Use HeaderNavigation to have sticky header
9cf67c9 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews labels Sep 20, 2022
@artonge artonge added this to the Nextcloud 25 milestone Sep 20, 2022
@artonge artonge self-assigned this Sep 20, 2022
@skjnldsv skjnldsv merged commit 38c61e0 into master Sep 20, 2022
@skjnldsv skjnldsv deleted the fix/make_timeline_header_sticky branch September 20, 2022 14:40
@marcelklehr
Copy link
Member

no compile?

@skjnldsv
Copy link
Member

@marcelklehr we're merging without because we're on a rush
we'll compile on master later on to avoid conflicts between all our PRs

@marcelklehr
Copy link
Member

okies

@blizzz blizzz mentioned this pull request Sep 22, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @marcelklehr @skjnldsv