Fix viewer editor permissions #1207
Conversation
skjnldsv
force-pushed
the
feat/permissions-editor-viewer
branch
from
394cdb4 to
e736024
Compare
skjnldsv
force-pushed
the
feat/permissions-editor-viewer
branch
from
e736024 to
d6a830a
Compare
| <d:getcontenttype /> | ||
| <d:getetag /> | ||
| <d:getlastmodified /> | ||
| <d:resourcetype /> | ||
| <nc:face-detections /> | ||
| <nc:file-metadata-size /> | ||
| <nc:has-preview /> | ||
| <nc:realpath /> | ||
| <oc:favorite /> | ||
| <d:resourcetype />` | ||
| <oc:fileid /> | ||
| <oc:permissions /> | ||
| ` |
There was a problem hiding this comment.
Any reason for the reordering ? just curious :)
There was a problem hiding this comment.
Sorting alphabetically. Easier to find what you want
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
artonge
force-pushed
the
feat/permissions-editor-viewer
branch
from
d6a830a to
510ab59
Compare
|
Would this be needed for the tags and people views as well? |
|
I think so indeed, @skjnldsv ^ |
Only if you open media on Viewer from those views 🤷 |
that's probably a yes... |
| @@ -109,13 +110,36 @@ private function formatData(iterable $nodes): array { | |||
| 'mime' => $node->getMimetype(), | |||
| 'size' => $node->getSize(), | |||
| 'type' => $node->getType(), | |||
| 'permissions' => $this->formatPermissions($node->getPermissions()), | |||
There was a problem hiding this comment.
Ah, and this is not the albums controller but the folders controller, probably, then we may need this for the actual albums as well
There was a problem hiding this comment.
Yep, but the other Views are importing src/services/DavRequest.js, so they will benefit from that too
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes, but Albums and Faces dav endpoints do not expose permissions in DAV afaik
Fix #315