-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scrolling for new design #1205
Conversation
Signed-off-by: Louis Chemineau <louis@chmn.me>
TagContent and floders views are also broken. Not sure about On this day, favorites, people and shared with you |
On this day and favorites are using the Timeline component so they are fixed by this PR. Can you push a fix for people and tags ? Should be the same logic as for Albums and AlbumContent |
@@ -530,14 +531,13 @@ export default { | |||
} | |||
|
|||
&__photos { | |||
height: 100%; | |||
height: calc(100% - 60px); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes FileListViewer the scrollable element, but shouldn't the app content be the scrollable element?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, we probably need vue v7 for that, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point, we don't really care which element is scrollable, no ?
Superseded by #1206 |
Signed-off-by: Louis Chemineau louis@chmn.me