Unify preview urls with the files app #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
fix/unified-preview-size
branch
from
daa0cbb
to
d2a0a7f
Compare
skjnldsv
reviewed
Feb 28, 2022
CarlSchwan
force-pushed
the
fix/unified-preview-size
branch
from
d2a0a7f
to
0e88828
Compare
skjnldsv
approved these changes
Apr 6, 2022
|
/rebase |
|
/compile amend / |
This has two advantages: * Increase the probability of browser cache hits * With the imaginary pipeline PR, requesting a preview of 250x250 is faster since there is less intermediate steps Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/unified-preview-size
branch
from
0e88828
to
ec05b4e
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two advantages:
since there are less intermediate steps. The resulting images send by the
server is still the same one.
Signed-off-by: Carl Schwan carl@carlschwan.eu